Skip to content

feat: no-mixing-controlled-and-uncontrolled #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: no-mixing-controlled-and-uncontrolled #486

wants to merge 5 commits into from

Conversation

@SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Apr 15, 2024

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • I have added a convincing reason for adding this feature, if necessary

Other information

@vercel
Copy link

vercel bot commented Apr 15, 2024

@SukkaW is attempting to deploy a commit to the Rel1cx's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eslint-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 6:35am

@Rel1cx Rel1cx force-pushed the main branch 2 times, most recently from d111cdb to 46e396e Compare May 21, 2024 15:32
@Rel1cx Rel1cx force-pushed the main branch 3 times, most recently from 6463592 to 4355255 Compare June 22, 2024 06:20
@Rel1cx Rel1cx force-pushed the main branch 6 times, most recently from 75c3ab6 to ea94363 Compare July 8, 2024 06:33
@Rel1cx Rel1cx force-pushed the main branch 7 times, most recently from 7775792 to e26b9cd Compare July 23, 2024 09:51
@Rel1cx Rel1cx force-pushed the main branch 2 times, most recently from c47e8d5 to de8599a Compare December 23, 2024 10:54
@Rel1cx Rel1cx force-pushed the main branch 6 times, most recently from 32b8a8b to 9ecd697 Compare January 27, 2025 13:24
@Rel1cx Rel1cx force-pushed the main branch 2 times, most recently from 5872bd9 to 7c41af6 Compare February 18, 2025 03:25
@Rel1cx Rel1cx force-pushed the main branch 3 times, most recently from 23d4df0 to 60b6e9f Compare February 25, 2025 03:50
@Rel1cx Rel1cx force-pushed the main branch 2 times, most recently from 94d033f to 611cc24 Compare March 10, 2025 20:14
@Rel1cx Rel1cx mentioned this pull request Apr 1, 2025
Open
@Rel1cx Rel1cx added Status: Triaging Issue is still being evaluated. PRs not yet accepted. and removed Status: On Hold The issue is currently on hold labels Apr 1, 2025
@zanminkian
Copy link

It seems that this rule only works for React built-in input component. What about Input components like imported from antd?

Personally, I suggest validating defaultValue and value of all react components, rather than only built-in input element.

@Rel1cx Rel1cx added Status: On Hold The issue is currently on hold and removed Status: Triaging Issue is still being evaluated. PRs not yet accepted. labels Oct 12, 2025
@Rel1cx
Copy link
Owner

Rel1cx commented Oct 12, 2025

It seems that this rule only works for React built-in input component. What about Input components like imported from antd?

Personally, I suggest validating defaultValue and value of all react components, rather than only built-in input element.

Thank you for raising this. It’s a key point I’m considering for this rule. Support for non-built-in components was also discussed in #1030. I’ll start implementing this rule once a clear best practice has been established.

@zanminkian zanminkian mentioned this pull request Oct 15, 2025
Open
@Rel1cx Rel1cx force-pushed the main branch 2 times, most recently from 94cd8f1 to 1470959 Compare October 27, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: On Hold The issue is currently on hold Type: New Rule Introduce a new rule

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SukkaW @zanminkian @Rel1cx